Skip to content

Conversation

@tilenkavcic
Copy link
Contributor

This updates IDM schema with updated custom object shards mentioned here.
It also brings the schema up to date with the latest features we introduced.

https://app.devrev.ai/devrev/works/ISS-189380

Copilot AI review requested due to automatic review settings July 3, 2025 09:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the initial mappings schema by adding support for custom object shard creation modes, introducing fallback handling, updating terminology capitalization, and embedding version metadata.

  • Added a discriminator and shard-mode enum for custom object mappings.
  • Defined a new fallback object and integrated it into typed references.
  • Introduced devrev_metadata_version and format_version fields and standardized “DevRev” casing.
Comments suppressed due to low confidence (3)

initial_mappings_schema.yaml:52

  • The shard-mode enum only includes create_shard, but the description mentions assigning an existing shard as well. Consider adding an enum value for existing shards or updating the description to match the supported modes.
        enum:

initial_mappings_schema.yaml:316

  • The new fallback property in airdrop-recipe-filter-typed-reference lacks a description. Please add a brief description explaining its purpose and usage.
            fallback:

initial_mappings_schema.yaml:521

  • The format: text declaration for format_version may not conform to OpenAPI format standards. Consider removing the format field or replacing it with a valid format or pattern definition.
        format: text

@tilenkavcic tilenkavcic changed the title Update IDM schema chore: Update IDM schema Jul 3, 2025
@patricijabrecko patricijabrecko merged commit 6fd5c46 into main Jul 4, 2025
2 checks passed
@patricijabrecko patricijabrecko deleted the tilenk/schema branch July 4, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants