Rate limit and attachment support #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjazerzen
requested review from
a team,
gasperzgonec,
patricijabrecko and
radovanjorgic
as code owners
patricijabrecko
approved these changes
Sep 23, 2025
gasperzgonec
pushed a commit
to devrev/airdrop-trello-snap-in
that referenced
this pull request
Oct 8, 2025
> Note: Should be reviewed alongside devrev/airdrop-shared#24. This PR introduces support for - Rate limiting (through proxy) - Attachments handling (I can now confirm that acceptance tests for attachment passing means that the attachments will also get extracted to the DevRev platform) - Simplify flow for the incremental mode NOTE: Regarding attachments: In Trello, you have to construct separate endpoint for streaming attachments (Refer to `trello-openapi-compact.yaml` for more. This is handled during attachment normalization phase (in data extraction). This endpoint has for some reason separate authentication. Changes include: - Simplify every acceptance test by removing text `Make sure to replace placeholders in the resource with The Trello API Key, The Trello OAuth Token, and The Organization ID.`. Instead, we do that only once on the toplevel and it seems to working fine - Acceptance tests in `Data fetching` for rate limiting (testing API calls rate limits directly) - Acceptance tests in `Pushing data to DevRev server` for rate limiting (testing if events get emitted properly) - Added instructions for constructing the attachment URL (Trello-specific) - Added acceptance test that actually tests if attachment extraction works - Added event payload for incremental mode - Simplify and improve acceptance test for incremental mode - Update `test_data/external_domain_metadata_event_payload.json` - Update `test_data/trello_external_sync_unit_check.json` - Updated `trello-openapi-compact.yaml` to: - Also include information about rate limiting documentation - Add docs for endpoint for streaming attachments Issues connected: - [ISS-217157](https://app.devrev.ai/devrev/works/ISS-217157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These were the changes needed while I was developing functionality for:
These changes include, but not limited to:
mock_devrev_server.pyattachment-extraction.mdtest_data/Related issues
https://app.devrev.ai/devrev/works/ISS-180117