Adding export option to excel (.xlsx)#22
Open
Zvikan wants to merge 2 commits intodevops-israel:masterfrom
Open
Adding export option to excel (.xlsx)#22Zvikan wants to merge 2 commits intodevops-israel:masterfrom
Zvikan wants to merge 2 commits intodevops-israel:masterfrom
Conversation
Author
|
Added some top padding in the export div so it will have some spacing between the region navigation list to the export button line. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #21 is still on not completed, I took it into my hands and completed some parts of it.
Notes:
Exporting everything right now will download multiple files, excel files per region.
The reasons I did it are:
@kesor I am not sure if I am completely happy with the select-box position right now, let me know what do you think I can move it around or add some extra padding to prettier it