- 
                Notifications
    
You must be signed in to change notification settings  - Fork 375
 
P9 #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            tarangs20
  wants to merge
  29
  commits into
  devops-dojo:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
tarangs20:p9
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            P9 #147
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    This sets up the repo to perform code coverage with the `check` target on gradle. We're also upgrading to gradle to 3.4 which adds support for `jacocoTestReport` and `jacocoTestCoverageVerification` targets. We comment out the settings.gradle to just have a focus in the exercise for the monolith. We might uncomment that again later.
Setup plugins for performing code coverage
This adds a variable called COVERAGE for test coverage so that we can build some peer exercises for working with environment variables that control our build.
variablize the coverage testing
verification was missing from some sub projects
Not all the sub-projects are ready for full coverage testing, so we're reducing the testing point lower than the highest testing point for other projects so that they always pass in favor of projects that are ready. If we test below that limit, then testing coverage can apply for these sub projects.
We need some sub-projects to have WIP coverage testing
fix service user with WIP
This tunes our coverage range to use the test cases that have the best coverage, but still enable lower coverage for other sub projects.
Tune coverage ranges
This is a bump for gradel wrapper to see if we can fix the java 9.0.1 build errors.
bumping to gradel 4.3.1 wrapper
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
test