done#155
Open
Dariadaria01 wants to merge 6 commits into
Open
Conversation
devmentor-pl
approved these changes
May 12, 2025
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Dario,
Bardzo dobrze sobie poradziłaś z zadaniami! 👍
Zostawiłem parę drobnych uwag w komentarzach.
| ); | ||
| const dataInfo = classElement.querySelectorAll('[data-info]'); | ||
| console.log(dataInfo.length); | ||
| } |
| const linksEl = document.querySelectorAll('[data-url]'); | ||
| linksEl.forEach((link) => { | ||
| const url = link.dataset.url; | ||
| if (url && url !== 'null') { |
Owner
There was a problem hiding this comment.
To sprawdzenie nie jest potrzebne - szykujesz elementy tylko z odpowiednim atrybutem tj data-url więc jak on nie będzie istniał to element nie zostanie wyszukany.
Zamiast linii od 6 do 9, wystarczy sama linia nr 7
| const parentElement = document.querySelector('.parent-for-button'); | ||
| if (parentElement) { | ||
| parentElement.appendChild(button); | ||
| } |
| const navElement = document.querySelector('nav'); | ||
| const ulElement = document.createElement('ul'); | ||
|
|
||
| menuItems.forEach((item) => { |
Owner
There was a problem hiding this comment.
Jak widać zdecydowanie wygodniej i lepiej używać pętli :)
Czasami trzeba rozpisać sobie krok po kroku, aby użyć pętli - to nie jest źle, ale ostateczna wersja powinna być z wykorzystaniem pętli.
|
|
||
| const articlesContainer = document.querySelector('.articles'); | ||
|
|
||
| articlesContainer.insertBefore(newArticle, articlesContainer.firstChild); |
devmentor-pl
approved these changes
May 22, 2025
| } else { | ||
| link.setAttribute('href', '#'); | ||
| } | ||
| link.setAttribute('href', url); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.