-
Notifications
You must be signed in to change notification settings - Fork 169
Complete all tasks #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MstowskaSandra
wants to merge
6
commits into
devmentor-pl:master
Choose a base branch
from
MstowskaSandra:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Complete all tasks #144
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9148d08
complete task 01
MstowskaSandra 2dae61e
complete task 02
MstowskaSandra 8847727
complete task 03
MstowskaSandra 827a5f3
complete task 04- complete all tasks
MstowskaSandra 38a7534
fix small bugs in tasks 02 and 03
MstowskaSandra 43f1b4f
add const result for safety
MstowskaSandra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,7 +47,9 @@ books.getTitle = function(isbn, lang) { | |
| } | ||
|
|
||
| const title =this[isbn].title; | ||
| return lang === 'en' ? title.en : title.pl; | ||
| if(typeof title[lang] !== 'undefined') { | ||
| return title[lang]; | ||
| } | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
| } | ||
|
|
||
| books.getTranslator = function(isbn, lang) { | ||
|
|
@@ -56,8 +58,12 @@ books.getTranslator = function(isbn, lang) { | |
| } | ||
|
|
||
| const translator = this[isbn].translator; | ||
| const result = translator[lang]; | ||
| return result === null ? false : result; | ||
|
|
||
| if(typeof translator[lang] === 'undefined') { | ||
| return false; | ||
| } | ||
|
|
||
| return translator[lang] === null ? false : translator[lang]; | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Można połączyć oba rozwiązania (moje i Twoje) tj. Może być bezpieczniejsze bo nie zrobimy nigdzie literówki powtarzając |
||
| } | ||
|
|
||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍