Skip to content

feat: Resolve basic objects tasks #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zanetasochon wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: Resolve basic objects tasks #141

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b281059
feat(1): Display object values
Apr 5, 2025
506c93c
feat(2): Display Calendar JS information
Apr 5, 2025
053cd73
feat(3): Display book details
Apr 5, 2025
64ff99d
feat(4): Compare user birth date with current date
Apr 5, 2025
94d5667
fix(3): Check if isbn is undefined
Apr 7, 2025
018f7f5
fix(3): Check if isbn is undefined
Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions 03/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ books.getAuthor = function (isbn) {
};

books.getTitle = function (isbn, lang) {
if (typeof this[isbn] === 'undefinej') {
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return null;
}

if (typeof this[isbn]['title'][lang] === 'undefined') {
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warto sprawdzić jeszcze poprzedni element tj. "isbin" jeśli ten element nie istnieje to kod rzuci błędem i przestanie działać reszta. Obecne rozwiązanie sprawdza tylko czy lang istnieje. Dlatego trzeba najpierw wykonać sprawdzenie:

if(typeof this[isbn] !== 'undefined') { ... }

return null;
}
Expand All @@ -55,6 +59,10 @@ books.getTitle = function (isbn, lang) {
};

books.getTranslator = function (isbn, lang) {
if (typeof this[isbn] === 'undefinej') {
Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return null;
}

if (typeof this[isbn]['translator'][lang] === 'undefined') {
return null;
}
Expand Down
2 changes: 1 addition & 1 deletion 04/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const user = {
firstName: 'Adam',
lastName: 'Nowak',
born: {
day: '05',
day: '06',
month: '04',
year: '2025',
},
Expand Down