Skip to content

feat: Resolve basic arrays tasks#142

Open
zanetasochon wants to merge 6 commits into
devmentor-pl:masterfrom
zanetasochon:master
Open

feat: Resolve basic arrays tasks#142
zanetasochon wants to merge 6 commits into
devmentor-pl:masterfrom
zanetasochon:master

Conversation

@zanetasochon
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Żaneto,

Tutaj również super! 👍
Z jedną drobną uwagą ;P

Comment thread 01/app.js
console.log('Pierwszy User to:', users[0]);
console.log('Trzeci User to:', users[2]);
console.log('Piąty User to:', users[4]);
console.log('Tablica zawiera' + ' ' + users.length + ' ' + 'elementów');
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 02/app.js

randomArray.forEach(function (element) {
console.log(element);
});
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/app.js

function numberOfYears(element) {
return currentYear - element;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/app.js Outdated
const numbers = [1, 2, 3, 4, 5, 6, 7];
const result = numbers.filter(EvenNumbers);

function EvenNumbers(evenNumber) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dlaczego z wielkie litery ta funkcja się zaczyna? Raczej powinna być z małej ;)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! U mnie w projektach funkcje nazywamy z dużej litery, siła przyzwyczajeń - poprawiam!

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/app.js
const result = numbers.filter(evenNumbers);

function EvenNumbers(evenNumber) {
function evenNumbers(evenNumber) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants