Skip to content

Tasks 01-05 Done#173

Open
TetraMeister wants to merge 5 commits into
devmentor-pl:masterfrom
TetraMeister:master
Open

Tasks 01-05 Done#173
TetraMeister wants to merge 5 commits into
devmentor-pl:masterfrom
TetraMeister:master

Conversation

@TetraMeister
Copy link
Copy Markdown

W Task04 trochę się zakręciłem dlatego zrobiłem v2 z poprawną, prostszą strukturą (potem w tasku05 mi się udało wykorzystać tą strukturę którą miałem na myśli w task04). Daj znać proszę czy taka forma zadania jest akceptowalna :D

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Łukaszu,

Całość prezentuje się bardzo dobrze 👍
Bez większych uwag :)

Comment thread 01/style.css
border-bottom-color: transparent;
border-bottom-color: transparent;

shape-outside: polygon(100% 0, 0 100%, 0 0);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 02/styles/global.css
". c b .";
grid-template-columns: auto minmax(auto, 600px) minmax(auto, 600px) auto;
grid-template-rows: repeat(2, 50vh);
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/desktop.css

.t p {
column-count: 2;
} No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/global.css

.p,
.t,
.v {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/tablet.css
column-count: 1;
column-rule: 1px solid black;
text-align: justify;
} No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

a {
text-decoration: none;
color: inherit;
} No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/index.html
<side class="v">V</side>

<main class="t">
<p>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeśli mamy tak dużo tekstu to dodałbym scrolla pionowego, aby treść nie wychodziła poza element lub nie dawał konkretnej wielkości dla niego, a pozwolił na rozpychanie -obecnie body ma 3x100vh i to ogranicza tekst.

Comment thread 04/Version1/index.html
</ul>
</nav>

</body>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/Version2/index.html

</body>

</html> No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/src/base/_global.scss
"s-second"
"foot";
grid-template-rows: 100px calc(100vh / 2 - 100px) calc(100vh / 2 - 100px) 100px;
} No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants