Skip to content

training done#164

Open
Neil-Gorski wants to merge 1 commit into
devmentor-pl:masterfrom
Neil-Gorski:master
Open

training done#164
Neil-Gorski wants to merge 1 commit into
devmentor-pl:masterfrom
Neil-Gorski:master

Conversation

@Neil-Gorski
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neil,

Całość prezentuje się bardzo dobrze 👍
Zostawiłem parę drobnych uwag.

Comment thread 01/style.css

shape-outside: polygon(0 0, 0% 100%, 100% 0);
margin-right: 20px;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 02/styles/global.css
} No newline at end of file
border-color: #baffc9;
grid-area: c;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/index.html
</iframe>
</div>
</body>
</html>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/global.css
} No newline at end of file
border-color: #baffc9;
grid-area: v;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/index.html
<div class="navbar__logo">
<img
class="navbar__logo-img"
src="./assets/logo.png"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uwaga na wielkość liter. Plik graficzny ma zapisane rozszerzone WIELKIMI literami. Na systema UNIX (linux, macos) ma to znaczenie.

Comment thread 04/index.html
<li class="navbar__list-item">
<a class="navbar__link" href="#">kontakt</a>
</li>
</ul>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/styles/desktop.css
color: #ffffff;
text-decoration: none;
white-space: nowrap;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/styles/mobile.css

.navbar__list-link {
font-size: 2em;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/styles/global.css
height: 100%;
padding: 10px;
border-radius: 50px;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/index.html
</p>
</div>
<div class="section-2__container">
<h2 class="section-2__title">Burrito</h2>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raczej staraj się bardziej określić co to za element zamiast pisać 1, 2 itp. - za miesiąc czy dwa te cyferki nic nie będą znaczyć. Co gorsza może się okazać że ich kolejność będzie do zmiany i wtedy będzie to wprowadzać niepotrzebny chaos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants