Skip to content

practice-html-and-css-rwd#160

Open
bartoszdudziak-dev wants to merge 5 commits into
devmentor-pl:masterfrom
bartoszdudziak-dev:master
Open

practice-html-and-css-rwd#160
bartoszdudziak-dev wants to merge 5 commits into
devmentor-pl:masterfrom
bartoszdudziak-dev:master

Conversation

@bartoszdudziak-dev
Copy link
Copy Markdown

Simple solutions to just complete the tasks

Copy link
Copy Markdown
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bartku,

Całość prezentuje się bardzo dobrze! 👍
Zostawiłem Ci drobną uwagę do zadania 05.

Comment thread 01/style.css
border-bottom-color: transparent;

shape-outside: polygon(100% 0, 0 100%, 0 0);
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 02/styles/global.css
max-width: 1200px;
margin-inline: auto;
}
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/index.html
></iframe
></side>
</body>
</html>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/desktop.css

width: min(1400px, 100%);
margin-inline: auto;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/global.css
top: 0;
height: 100%;
width: 100%;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 03/styles/tablet.css
"V T";

grid-template-columns: minmax(200px, 50%) 1fr;
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/index.html
</li>
<li class="nav__item">
<a class="nav__link" href="#item2.2">Item 2.2</a>
</li>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 04/styles/index.css
.hamburger-checkbox:checked + .nav__menu {
margin-top: 0rem;
}
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread 05/index.html
<link rel="stylesheet" href="./styles/index.css" />
</head>
<body>
<header class="fullWidth">
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raczej trzymałbym się jednej formy pisania klas albo 'fullWidth' albo full-width - mieszanie nie jest dobrze oceniane

Comment thread 05/styles/index.css
display: block;
position: static;
}
}
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants