Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve record analyzer performance #61

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Improve record analyzer performance #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions src/StructId.Analyzer/RecordAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,31 +22,42 @@ public override void Initialize(AnalysisContext context)
if (!Debugger.IsAttached)
context.EnableConcurrentExecution();

context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.ClassDeclaration);
context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.StructDeclaration);
context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.RecordDeclaration);
context.RegisterSyntaxNodeAction(Analyze, SyntaxKind.RecordStructDeclaration);
context.RegisterCompilationStartAction(start =>
{
var known = new KnownTypes(start.Compilation);
if (known.IStructId is null || known.IStructIdT is null)
return;

start.RegisterSymbolAction(AnalyzeSymbol, SymbolKind.NamedType);
});
}

static void Analyze(SyntaxNodeAnalysisContext context)
static void AnalyzeSymbol(SymbolAnalysisContext context)
{
if (context.Symbol is not INamedTypeSymbol symbol)
return;

var known = new KnownTypes(context.Compilation);

if (context.Node is not TypeDeclarationSyntax typeDeclaration ||
known.IStructIdT is not { } structIdTypeOfT ||
known.IStructId is not { } structIdType)
// We only care about IStructId and IStructId<T>
if (!symbol.Is(known.IStructId) && !symbol.Is(known.IStructIdT))
return;

var symbol = context.SemanticModel.GetDeclaredSymbol(typeDeclaration);
if (symbol is null)
// We can only analyze if there's a declaration in source.
if (symbol.DeclaringSyntaxReferences.Length == 0 ||
symbol.DeclaringSyntaxReferences
.Select(x => x.GetSyntax())
.OfType<TypeDeclarationSyntax>()
.FirstOrDefault() is not { } typeDeclaration)
return;

if (!symbol.Is(structIdType) && !symbol.Is(structIdTypeOfT))
return;
// TODO: report or ignore if more than one declaration?

// If there's only one declaration and it's not partial
var report = symbol.DeclaringSyntaxReferences.Length == 1 && !typeDeclaration.Modifiers.Any(SyntaxKind.PartialKeyword);
report |= !typeDeclaration.IsKind(SyntaxKind.RecordStructDeclaration) || !symbol.IsReadOnly;
var report = symbol.DeclaringSyntaxReferences.Length == 1 &&
!typeDeclaration.Modifiers.Any(SyntaxKind.PartialKeyword);

report |= !symbol.IsRecord || symbol.TypeKind != TypeKind.Struct || !symbol.IsReadOnly;

if (report)
{
Expand All @@ -55,7 +66,7 @@ known.IStructIdT is not { } structIdTypeOfT ||
else if (typeDeclaration.BaseList?.Types.FirstOrDefault(t => t.Type is IdentifierNameSyntax { Identifier.Text: "IStructId" }) is { } implementation)
context.ReportDiagnostic(Diagnostic.Create(MustBeRecordStruct, implementation.GetLocation(), symbol.Name));
else
context.ReportDiagnostic(Diagnostic.Create(MustBeRecordStruct, typeDeclaration.Identifier.GetLocation(), symbol.Name));
context.ReportDiagnostic(Diagnostic.Create(MustBeRecordStruct, symbol.Locations.FirstOrDefault(), symbol.Name));
}

if (typeDeclaration.ParameterList is null)
Expand All @@ -72,6 +83,5 @@ known.IStructIdT is not { } structIdTypeOfT ||
var parameter = typeDeclaration.ParameterList.Parameters[0];
if (parameter.Identifier.Text != "Value")
context.ReportDiagnostic(Diagnostic.Create(MustHaveValueConstructor, parameter.Identifier.GetLocation(), symbol.Name));

}
}
Loading