Skip to content

Commit

Permalink
Use cert-manager to generate certs for tests (apache#306)
Browse files Browse the repository at this point in the history
* Use cert-manager to generate certs for tests

* Install Cert-Manager in test env

### Motivation

Currently, we use hard coded certificates for the tests. Instead, we can use Cert Manager to generate the certificates. The primary benefit of this change is that it ensure we're testing the cert manager integration.

### Modifications

* Remove `.ci/tls` directory since we no longer need these certs.
* Remove `scripts/pulsar/clean_tls.sh` (it wasn't used)
* Remove `scripts/pulsar/upload_tls.sh` since we are not uploading any certs
* Update the `helm.sh` test script
* Update the `.ci/clusters` configurations to generate the relevant cert manager manifests

### Verifying this change

- [ ] Make sure that the change passes the CI checks.
  • Loading branch information
michaeljmarshall authored Oct 19, 2022
1 parent 816d88c commit 62a0d2b
Show file tree
Hide file tree
Showing 34 changed files with 16 additions and 1,011 deletions.
5 changes: 3 additions & 2 deletions .ci/clusters/values-bk-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ tls:
bookie:
enabled: true

# disable cert manager
# enable cert-manager
certs:
internal_issuer:
enabled: false
enabled: true
type: selfsigning
5 changes: 3 additions & 2 deletions .ci/clusters/values-broker-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ tls:
broker:
enabled: true

# disable cert-manager
# enable cert-manager
certs:
internal_issuer:
enabled: false
enabled: true
type: selfsigning
5 changes: 3 additions & 2 deletions .ci/clusters/values-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ tls:
zookeeper:
enabled: true

# disable cert-manager
# enable cert-manager
certs:
internal_issuer:
enabled: false
enabled: true
type: selfsigning
5 changes: 3 additions & 2 deletions .ci/clusters/values-zk-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ tls:
zookeeper:
enabled: true

# disable cert manager
# enable cert-manager
certs:
internal_issuer:
enabled: false
enabled: true
type: selfsigning
5 changes: 3 additions & 2 deletions .ci/clusters/values-zkbk-tls.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ tls:
bookie:
enabled: true

# disable cert manager
# enable cert-manager
certs:
internal_issuer:
enabled: false
enabled: true
type: selfsigning
2 changes: 1 addition & 1 deletion .ci/helm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ function ci::install_pulsar_chart() {

echo "Installing the pulsar chart"
${KUBECTL} create namespace ${NAMESPACE}
ci::install_cert_manager
echo ${CHARTS_HOME}/scripts/pulsar/prepare_helm_release.sh -k ${CLUSTER} -n ${NAMESPACE} ${extra_opts}
${CHARTS_HOME}/scripts/pulsar/prepare_helm_release.sh -k ${CLUSTER} -n ${NAMESPACE} ${extra_opts}
${CHARTS_HOME}/scripts/pulsar/upload_tls.sh -k ${CLUSTER} -n ${NAMESPACE} -d ${PULSAR_HOME}/.ci/tls
sleep 10

echo ${HELM} install --set initialize=true --values ${value_file} ${CLUSTER} ${CHARTS_HOME}/charts/pulsar
Expand Down
34 changes: 0 additions & 34 deletions .ci/tls/certs/ca.cert.pem

This file was deleted.

54 changes: 0 additions & 54 deletions .ci/tls/private/ca.key.pem

This file was deleted.

34 changes: 0 additions & 34 deletions .ci/tls/servers/bookie/bookie.cert.pem

This file was deleted.

18 changes: 0 additions & 18 deletions .ci/tls/servers/bookie/bookie.csr.pem

This file was deleted.

28 changes: 0 additions & 28 deletions .ci/tls/servers/bookie/bookie.key-pk8.pem

This file was deleted.

27 changes: 0 additions & 27 deletions .ci/tls/servers/bookie/bookie.key.pem

This file was deleted.

34 changes: 0 additions & 34 deletions .ci/tls/servers/broker/broker.cert.pem

This file was deleted.

18 changes: 0 additions & 18 deletions .ci/tls/servers/broker/broker.csr.pem

This file was deleted.

28 changes: 0 additions & 28 deletions .ci/tls/servers/broker/broker.key-pk8.pem

This file was deleted.

Loading

0 comments on commit 62a0d2b

Please sign in to comment.