Add algorithms selection to /cog/viewer #1119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The algorithms not applicable to 3b or 1b or disabled in the selector within the updateViz function
7 tasks
|
Quick note, could not find where icons are taken from, tried functions/calculator/etc but no luck. |
|
I think they are from https://labs.mapbox.com/assembly/icons/ |
|
This one should be good to merge as well from my point of view, don't hesitate if you have any feedback or would like to remove some things (like expression support)! |
|
as I said earlier I'm trying to find spare time to do Open source work but for now I have some paid project work to do I'm sorry @jo-chemla |
|
Hi again, sorry for the bad wording, just wanted to add that final comment for validation after all my commits, and of course no need to rush, this PR should follow the standard merge/release cycles, whenever time allows. And thanks for all the great work as always! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1116 extract
/cog/viewerPR into this oneBelow comment now tackled!
Note from Vincent: FYI I've started a PR in rio-viz to support raster-dem viz developmentseed/rio-viz#64 ;-)