Added support for linux distros as well (ubuntu 24) mainly #290
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| /** @type {import('./lib/types').Configuration} */ | ||
| export default { | ||
| '*': [() => 'bun run typecheck', 'bun run lint', 'bun run format'] | ||
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| { | ||||||
| "name": "treo", | ||||||
| "version": "1.2.0", | ||||||
| "description": "An Electron application with React and TypeScript", | ||||||
| "main": "./out/main/index.js", | ||||||
| "author": "your-ehsan", | ||||||
|
|
@@ -18,14 +18,14 @@ | |||||
| "lint": "eslint . --fix", | ||||||
| "typecheck:node": "tsc --noEmit -p tsconfig.node.json --composite false", | ||||||
| "typecheck:web": "tsc --noEmit -p tsconfig.web.json --composite false", | ||||||
| "typecheck": "bun run typecheck:node && bun run typecheck:web", | ||||||
| "start": "electron-vite preview", | ||||||
| "dev": "electron-vite dev", | ||||||
| "build": "cross-env GENERATE_SOURCEMAP=false \"bun run typecheck && electron-vite build\"", | ||||||
|
||||||
| "build": "cross-env GENERATE_SOURCEMAP=false \"bun run typecheck && electron-vite build\"", | |
| "build": "bun run typecheck && cross-env GENERATE_SOURCEMAP=false electron-vite build", |
🤖 Prompt for AI Agents
In package.json around line 24, the build script currently wraps the whole chain
in quotes so cross-env receives a single argument and GENERATE_SOURCEMAP is not
applied to the second command (breaking on Windows); remove the quotes and
ensure cross-env is applied to both commands (e.g. run cross-env
GENERATE_SOURCEMAP=false before bun run typecheck and again before electron-vite
build, separated by &&) so the env var is correctly set for each spawned
process.
Contributor
There was a problem hiding this comment.
🛠️ Refactor suggestion
Replace ‘bun rebuild’ with Electron-aware rebuild to support native modules on Linux/Win.
Bun doesn’t provide a dedicated bun rebuild for Electron-native modules; standard practice is @electron/rebuild to match Electron’s ABI (v38 here). This avoids runtime “NODE_MODULE_VERSION” mismatches for better-sqlite3 across Linux distros and Windows. (electronjs.org)
Apply:
- "rebuild:drizzle": "bun rebuild better-sqlite3",
+ "rebuild:drizzle": "electron-rebuild -f -w better-sqlite3",Also add the dev dependency:
{
"devDependencies": {
"@electron/rebuild": "^3.6.0"
}
}Note: postinstall already runs electron-builder install-app-deps, which helps rebuild; keeping an explicit script is still useful locally/CI. (electronjs.org)
🤖 Prompt for AI Agents
In package.json around line 25, the npm script uses "bun rebuild better-sqlite3"
which doesn't rebuild native modules against Electron's ABI; replace that script
with an Electron-aware rebuild command (use @electron/rebuild targeting Electron
ABI v38) and add "@electron/rebuild": "^3.6.0" to devDependencies so native
modules like better-sqlite3 are rebuilt correctly on Linux/Windows for Electron;
keep postinstall as-is but include the explicit script for local/CI usage.
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
coderabbitai[bot] marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Use GH_TOKEN, split the command, and drop unnecessary checkout
GH_TOKENoverGITHUB_TOKENfor gh CLI.gh properations; removing it reduces surface area and speeds up the job.Additionally:
GH_TOKEN: ${{ secrets.PAT }}instead ofGITHUB_TOKEN.actions/checkout@v4step entirely since it’s not needed here.📝 Committable suggestion
🤖 Prompt for AI Agents