Skip to content

Claude #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Claude #116

wants to merge 4 commits into from

Conversation

bertlebee
Copy link

add support for claude code as a feature

@bertlebee bertlebee mentioned this pull request Apr 18, 2025
@koralowiec koralowiec self-requested a review April 22, 2025 08:57
@koralowiec koralowiec added the new feature This PR or issue is about adding a new Dev Container feature label Apr 22, 2025
Copy link
Member

@koralowiec koralowiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR!

I have a single comment - Typically, we use npm-package feature to install npm packages globally (if there's node already installed, the feature uses it; otherwise it installs node on its own).

I suggested the changes

Comment on lines +14 to +19
# Install Claude Code globally via npm
if [ "${VERSION}" = "latest" ]; then
npm install -g "@anthropic-ai/claude-code"
else
npm install -g "@anthropic-ai/claude-code@${VERSION}"
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Install Claude Code globally via npm
if [ "${VERSION}" = "latest" ]; then
npm install -g "@anthropic-ai/claude-code"
else
npm install -g "@anthropic-ai/claude-code@${VERSION}"
fi
$nanolayer_location \
install \
devcontainer-feature \
"ghcr.io/devcontainers-extra/features/npm-package:1.0.3" \
--option package='@anthropic-ai/claude-code' --option version="$VERSION"

Comment on lines +4 to +7
"features": {
"ghcr.io/devcontainers/features/node:1": {},
"claude-code": {}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"features": {
"ghcr.io/devcontainers/features/node:1": {},
"claude-code": {}
}
"features": {
"claude-code": {}
}

Comment on lines +11 to +16
"features": {
"ghcr.io/devcontainers/features/node:1": {},
"claude-code": {
"version": "0.2.70"
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"features": {
"ghcr.io/devcontainers/features/node:1": {},
"claude-code": {
"version": "0.2.70"
}
}
"features": {
"claude-code": {
"version": "0.2.70"
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This PR or issue is about adding a new Dev Container feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants