-
Notifications
You must be signed in to change notification settings - Fork 19
Claude #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Claude #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR!
I have a single comment - Typically, we use npm-package
feature to install npm packages globally (if there's node already installed, the feature uses it; otherwise it installs node on its own).
I suggested the changes
# Install Claude Code globally via npm | ||
if [ "${VERSION}" = "latest" ]; then | ||
npm install -g "@anthropic-ai/claude-code" | ||
else | ||
npm install -g "@anthropic-ai/claude-code@${VERSION}" | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Install Claude Code globally via npm | |
if [ "${VERSION}" = "latest" ]; then | |
npm install -g "@anthropic-ai/claude-code" | |
else | |
npm install -g "@anthropic-ai/claude-code@${VERSION}" | |
fi | |
$nanolayer_location \ | |
install \ | |
devcontainer-feature \ | |
"ghcr.io/devcontainers-extra/features/npm-package:1.0.3" \ | |
--option package='@anthropic-ai/claude-code' --option version="$VERSION" |
"features": { | ||
"ghcr.io/devcontainers/features/node:1": {}, | ||
"claude-code": {} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"features": { | |
"ghcr.io/devcontainers/features/node:1": {}, | |
"claude-code": {} | |
} | |
"features": { | |
"claude-code": {} | |
} |
"features": { | ||
"ghcr.io/devcontainers/features/node:1": {}, | ||
"claude-code": { | ||
"version": "0.2.70" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"features": { | |
"ghcr.io/devcontainers/features/node:1": {}, | |
"claude-code": { | |
"version": "0.2.70" | |
} | |
} | |
"features": { | |
"claude-code": { | |
"version": "0.2.70" | |
} | |
} |
add support for claude code as a feature