Refactor: Redis Conn Test에 try-with-resources 적용#20
Merged
Dockerel merged 1 commit intodev-DDIP:mainfrom Aug 3, 2025
Dockerel:Refactor/issue-#19
Merged
Refactor: Redis Conn Test에 try-with-resources 적용#20Dockerel merged 1 commit intodev-DDIP:mainfrom Dockerel:Refactor/issue-#19
Dockerel merged 1 commit intodev-DDIP:mainfrom
Dockerel:Refactor/issue-#19
Conversation
GitJIHO
reviewed
Aug 3, 2025
Contributor
GitJIHO
left a comment
There was a problem hiding this comment.
감사합니다 👍 꼼꼼한 확인 덕분에 좀 더 완성도 높은 코드가 된 것 같네요!
GitJIHO
approved these changes
Aug 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📚 배경
MySQL Conn Test에는 try-with-resources가 적용되어 있는데 Redis Conn Test에는 적용되어 있지 않아 해당 부분을 수정하였습니다.
📝 작업 내용
1. Redis Conn Test에 try-with-resources 저장
2. connection.ping()이 이미 String을 반환하여 String으로 감싼 부분 제거
📸 스크린샷
x
💬 리뷰 요구사항
x
✏ Git Close
close #19