fix(web): rate-limit /api/docs/search - #1017
Merged
Merged
Conversation
The route had zero throttling beyond a 128-char query cap, unlike every other demo endpoint. A scripted client could hit it at unlimited req/s from one IP. Reuse the existing in-memory clientIp/checkWebhookCooldown pair from lib/demo-limits.ts, same pattern as /api/webhook-sample. SearchDialog cast res.json() straight to SearchResult[] with no res.ok check, so a 429 envelope would have been treated as a result array and broken rendering - fixed alongside the rate limit that would trigger it.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/docs/searchhad zero throttling beyond a 128-char query cap while every other demo endpoint has a rate limit. Reuses the existingclientIp/checkWebhookCooldownpair fromlib/demo-limits.ts, same pattern as/api/webhook-sample.SearchDialogcastres.json()straight toSearchResult[]with nores.okcheck, so a 429 envelope would have broken rendering - fixed alongside the rate limit that would trigger it.Test plan
pnpm tsc --noEmit -p apps/web/tsconfig.jsoncleanpnpm --filter orbital/web buildclean