Skip to content

fix: bubble up bad request error message to user & skip response format in completion request if not provided #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aavshr merged 3 commits into from
Oct 25, 2025
Merged

fix: bubble up bad request error message to user & skip response format in completion request if not provided #41

aavshr merged 3 commits into from
Oct 25, 2025

Conversation

@aavshr
Copy link
Collaborator

@aavshr aavshr commented Oct 24, 2025 •
edited
Loading

Changes

  • Bubble up bad request response text in error and fix wrong content policy msg
  • Get rid of unused toasts and unreachable code in TextResource component
  • Skip response_format in completion api request instead of null encoding, this caused some completion API providers to fail parsing the request

Fixes #34

@aavshr aavshr changed the title fix: fix wrong handling of bad requests with content policy message and skip response format in completion request if not provided fix: bubble up bad request error message to user & skip response format in completion request if not provided Oct 24, 2025
@aavshr aavshr merged commit 22678e1 into main Oct 25, 2025
2 checks passed
@aavshr aavshr deleted the aavash/fix-bad-response-handling branch October 25, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MaximilianHeidenreich MaximilianHeidenreich MaximilianHeidenreich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Content Policy?

2 participants

@aavshr @MaximilianHeidenreich