Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for simulating calibration exposures #61

Merged
merged 5 commits into from
Apr 14, 2017
Merged

Add support for simulating calibration exposures #61

merged 5 commits into from
Apr 14, 2017

Conversation

dkirkby
Copy link
Member

@dkirkby dkirkby commented Apr 14, 2017

From the updated simulate() docstring:

        Calibration exposures can be simulated by providing an array of
        ``calibration_surface_brightness`` values to use.  In this case,
        the source and fiberloss inputs are ignored, and no atmospheric
        emission or extinction are applied.

I added some examples to the bottom of the tutorial notebook.

@dkirkby
Copy link
Member Author

dkirkby commented Apr 14, 2017

Basic usage example:

sbunit = u.erg / (u.Angstrom * u.s * u.cm ** 2 * u.arcsec ** 2)
flat_lamp = 2e-13 * np.ones((desi.num_fibers, num_wlen)) * sbunit
desi.observation.exposure_time = 10 * u.s
desi.simulate(calibration_surface_brightness=flat_lamp, focal_positions=xy)

Calibration is implemented via:

  • source_flux = surface_brightness * fiber_area
  • fiberloss = 1
  • sky emission = 0
  • no sky extinction applied

Since the user provides a surface brightness for each fiber, arbitrarily complex illumination models are supported, but are not modeled within specsim. Vignetting should be implemented in specsim, and included here, but is not yet #56.

Fibers can be positioned either directly in (x,y) or via (ra, dec), as for non-calibration exposures.

Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just what I need. Please merge when ready. Thanks.

@dkirkby dkirkby merged commit 487d7e7 into master Apr 14, 2017
@dkirkby dkirkby deleted the calib branch April 14, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants