Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default DESI_SPECTRO_REDUX #2448

Merged
merged 3 commits into from
Mar 6, 2025
Merged

default DESI_SPECTRO_REDUX #2448

merged 3 commits into from
Mar 6, 2025

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Mar 4, 2025

This PR makes $DESI_SPECTRO_REDUX optional for the purposes of desispec.io.findfile. If it is set, it will be used just like it currently is, but if not set it will default to $DESI_ROOT/spectro/redux. I updated the tests to confirm this behavior. The motivation for this is to make the required environment setup for end-users as simple as possible, in particular for the tutorials ($DESI_ROOT will be the only required environment variable for end-user analysis, while still allowing $DESI_SPECTRO_REDUX override). Ditto for $DESI_SPECTRO_DATA defaulting to $DESI_ROOT/spectro/data if not set.

I did not scrub $DESI_SPECTRO_REDUX from absolutely everywhere in desispec, so I suggest that we continue to set it and use it like before. I did update two custom path creations with their equivalent findfile invocations.

@sbailey sbailey requested a review from akremin March 4, 2025 21:32
@coveralls
Copy link

coveralls commented Mar 4, 2025

Coverage Status

coverage: 38.991% (+0.002%) from 38.989%
when pulling b2893af on default_redux
into 0852688 on main.

Copy link
Member

@akremin akremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the updates look good and bonus points for the changes.rst update and unit tests. I have one quick request inline that should be trivial to change.

@sbailey sbailey merged commit 2019a32 into main Mar 6, 2025
26 checks passed
@sbailey sbailey deleted the default_redux branch March 6, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants