Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
$DESI_SPECTRO_REDUX
optional for the purposes ofdesispec.io.findfile
. If it is set, it will be used just like it currently is, but if not set it will default to$DESI_ROOT/spectro/redux
. I updated the tests to confirm this behavior. The motivation for this is to make the required environment setup for end-users as simple as possible, in particular for the tutorials ($DESI_ROOT
will be the only required environment variable for end-user analysis, while still allowing$DESI_SPECTRO_REDUX
override). Ditto for$DESI_SPECTRO_DATA
defaulting to$DESI_ROOT/spectro/data
if not set.I did not scrub
$DESI_SPECTRO_REDUX
from absolutely everywhere in desispec, so I suggest that we continue to set it and use it like before. I did update two custom path creations with their equivalentfindfile
invocations.