Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the resolution matrix when doing flux calibration #2423

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Dec 4, 2024

This addresses #2419

@segasai segasai added the WIP Work in Progress label Dec 4, 2024
@segasai segasai removed the WIP Work in Progress label Dec 4, 2024
@segasai
Copy link
Contributor Author

segasai commented Dec 4, 2024

I think this patch is ready.
The new tests check the following.

  1. If the calibration factor is constant then the resolution matrix should not change
  2. If before calibration the extracted flux was subject to the condition
    $F= R * F_0$, where R is resolution matrix
    then after the calibration it should be subject to:
    $F_c = R_c * F_{0,c}$
    where $F_{0,c} = C^{-1} F_0$, and $R_c$ is the new resolution matrix

I also test the masked calibration case that it still works. For that test I use a constant calibration vector.

@coveralls
Copy link

coveralls commented Dec 4, 2024

Coverage Status

coverage: 28.307% (-1.7%) from 30.053%
when pulling 34931c9 on fluxcalib_resol
into 38acb7f on main.

@segasai segasai changed the title Correct the resolution matrix when doing flux calibration Adjust the resolution matrix when doing flux calibration Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants