Skip to content

chore(webapp): update vite & sass #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jan 29, 2025

No description provided.

Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I wonder why dependabot hasn't caught this. The bot recently left a note that it doesn't support our npm version; however, we're using node:lts, so I was suprised by that note. Do you think this is related, or do you have any other thoughts?

@peterthomassen peterthomassen merged commit 9edbf3b into desec-io:main Jan 29, 2025
5 checks passed
@Rotzbua
Copy link
Contributor Author

Rotzbua commented Jan 29, 2025

Guess: the min dependency is parsed as required min supported version?

"node": ">=18"

edit: Seems that the currently as lts docker distributed version is 22

@Rotzbua Rotzbua deleted the chore_up_vite branch January 29, 2025 22:46
@peterthomassen
Copy link
Member

Mh. It seems like dependabot's support for npm version 6 was discontinued on January 20.

However, according to https://nodejs.org/en/about/previous-releases#looking-for-the-latest-release-of-a-version-branch, it seems like node 18 comes with npm 10, so that can't be it. 🤷

On another note: Are you interested in working on #699? - If you reach out via email, we might also make a paid arrangement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants