RoomImpulseResponse Transform: Support for stereo/multi-channel IRs #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crlandsc
changed the title
…reo/multi-channel IRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using stereo/multi-channel IRs, this error is thrown:
RuntimeError: a Tensor with 2 elements cannot be converted to ScalarThis is due to
-idx[i].item()having multiple entries from the multiple channels.Adding
.min()to-idx[i].min().item()selects the earliest index of all of the channels to rotate the IR by. This makes it compatible with multi-channel IRs and avoids potentially cutting off parts of the IR.Addendum:
Refactorring
window_idx = early_idx[idx, 0].nonzero()towindow_idx = early_idx[idx, :].nonzero()is also required to support multi-channel IRs.