Skip to content

feat: Intent Contracts #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0xdomrom merged 24 commits into from
Jun 17, 2025
Merged

feat: Intent Contracts #4

0xdomrom merged 24 commits into from
Jun 17, 2025

Conversation

@antoncoding
Copy link
Contributor

@antoncoding antoncoding commented Feb 16, 2025 •
edited
Loading

TLDR

  • IntentExecutorBase: a shared function across all intent contracts (might be renamed to IntentBase if more features are added).
    • Add rescueToken so the owner can transfer stuck ERC20 tokens.
  • SubaccountDepositIntent: Allows executors to move funds into subaccounts.
  • WithdrawBridgeIntent: Allows executors to move funds off Derive through bridges
  • StakeDRVIntent: Allows executors to stake approved DRV to staking contract

Running the test

forge test --match-contract FORK_LYRA_ --fork-url https://rpc.lyra.finance/

Notes

  • The test contract is still prefixed with FORK_LYRA_, not FORK_DERIVE to remain compatible with existing CICD.

@antoncoding antoncoding changed the title feat: DepositIntent feat: Deposit Intent Feb 16, 2025
@antoncoding antoncoding changed the title feat: Deposit Intent feat: Intent Contracts Feb 17, 2025
0xdomrom
0xdomrom reviewed Feb 17, 2025
View reviewed changes
@antoncoding
chore: rename constant
47aa4ad
@antoncoding
test: add unit tests for buckets
3093bd5
@antoncoding
fix: [audit-m1] rugpull by exploited executor key with malicious Deri…
9964159 
…ve Asset (#2)

* fix: [audit-m1] rugpull by exploited executor key with malicious Derive Asset

* alternative fix: use manager whitelist  (#5)

* fix2: use manager whitelist instead

* chore: makes USDC work
@antoncoding
fix: [audit-low-1] Fail-open pattern on maxFee (#3)
0b4ba73
@antoncoding
fix: [informational] All informational findings (#4)
1cd53d6 
* fix: informational fixes

* chore: correct fix of transfer

* fix: correct fix of rescueToken
@0xdomrom 0xdomrom merged commit 290518e into derivexyz:master Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xdomrom 0xdomrom 0xdomrom left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@antoncoding @0xdomrom