Switch to Attribute::Storage for dealing with method annotations #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current manual implementation for attributes is not very composable, partly due to the way attributes are implemented in Perl (via
MODIFY_CODE_ATTRIBUTES).Attribute::Storage provides an API which abstracts out much of the work we were doing before, and has the advantage that any service which wants to extend
RPC/Emitter/Receivermethods can do so by creating its own attributes via that interface, without losing the original attribute behaviour for the built-in RPC/etc. in the process.This is particularly relevant for cases where permissions need to be checked before RPC methods can run, or if we want to track additional metrics on input/output for our methods.