Only enable OpenTelemetry when explicitly requested #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid loading or calling OpenTelemetry unless explicitly enabled, e.g. via
This is due to stability problems relating to
dynamically
and cancellation/exception handling: especially on recent versions of Perl, we're seeing various memory corruption issues. Since this is supposed to be an opt-in feature, due to performance hit and that it's not useful without the OpenTelemetry endpoint and infrastructure available, disabling by default was the intended direction anyway.Symptoms include:
and segmentation faults.
This change attempts to bypass OpenTelemetry (including module load) unless the
USE_OPENTELEMETRY
environment variable is set. Previously, we'd be creating contexts and spans in some places regardless of whether it was enabled.