Pin XS::Parse::Keyword to working version, due to 0.43 breakage #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header files can no longer be found by dependent modules, e.g.
Syntax::Keyword::Match, due to this change:
```
* Use `File::ShareDir` for storing .h include files, rather than
storing the contents in the `__DATA__` section of the build helpers
```
Pinning to a working version for now.
Symptoms are errors such as these in `cpanm` installation logs:
```
lib/Syntax/Keyword/Match.xs:18:10: fatal error: hax/perl-backcompat.c.inc: No such file or directory
18 | #include "hax/perl-backcompat.c.inc"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header files can no longer be found by dependent modules, e.g. Syntax::Keyword::Match, due to this change:
Pinning to a working version for now.
Symptoms are errors such as these in
cpanminstallation logs: