feature/batch_ack #309
Merged
feature/batch_ack #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When subscription or RPC items have been processed, the Redis implementation was issuing a separate
XACKfor every ID. This can lead to a lot of network traffic and unnecessary delay between completing items and receiving new ones.The change here combines multiple IDs into a single
XACKcall, meaning that we are now closer to symmetry between theXREADGROUPto get the work, and theXACKto report completion. The ordering is also changed so that we avoid a roundtrip before we can start receiving items: instead, we issue all theXACKs and immediately request theXREADGROUP.