fix: fix RPC behavior when exception is thrown across boundary #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nael-binary
reviewed
Feb 21, 2024
tom-binary
reviewed
Feb 28, 2024
address reviews Reintroduces the does shim This reverts commit 132b176. address review from tom
ngeojiajun-deriv
force-pushed
the
fix/proper-exception-marshalling
branch
from
132b176 to
4ae4951
Compare
nael-binary
reviewed
Feb 28, 2024
nael-binary
reviewed
Feb 28, 2024
tom-binary
reviewed
Jul 17, 2024
tom-binary
added a commit
to tom-binary/perl-Myriad
that referenced
this pull request
Jul 22, 2024
We rely on `UNIVERSAL::DOES` here. https://metacpan.org/pod/UNIVERSAL#$obj-%3EDOES(-ROLE-) See also pull request deriv-com#301, which has a similar fix.
…oper-exception-marshalling
|
Since there's not been any progress on this for a few months, I've merged #353 for basic exception support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When an error is thrown by the listener, it is never deal properly by either client or the server side. Resulting to the following problems depending on the exception thrown.
Myriad::Exceptionimplementers) would cause immediate crash which would cause the Future for processing the RPC calls cancelled.die) would cause caller to getundefas result instead of exceptions getting thrown.doesmethod, causing the (1) to happenChanges
This PR contains breaking changes, please test it before merge
call_rpcwould rethrow all exceptions from the RPC server asMyriad::Exception::RPC::RemoteException