Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ahmad/YAxis Seperations #311

Merged
merged 30 commits into from
Jul 2, 2024
Merged

Ahmad/YAxis Seperations #311

merged 30 commits into from
Jul 2, 2024

Conversation

ahmadtaimoor-deriv
Copy link
Contributor

@ahmadtaimoor-deriv ahmadtaimoor-deriv commented May 13, 2024 •
edited
Loading

This PR contains the following changes:

We've implemented a technique where the canvas is clipped for all drawing painters, ensuring that any drawings beyond the bounds of the chart are neatly trimmed. All painters used in the chart now include a clipping function that restricts the drawing within the predefined bounds of the y-axis.

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

As a creator of this PR:

As a reviewer I ensure that:

  • ✴️ This PR follows the standard PR template.
  • 🪩 The information in this PR properly reflects the code changes.
  • 🧪 All the necessary tests for this PR's are passing.

Pre-launch Checklist (For QA)

  • 👌 It passes the acceptance criteria.

Pre-launch Checklist (For Maintainer)

  • [MAINTAINER_NAME] I make sure this PR fulfills its purpose.

@balakrishna-deriv balakrishna-deriv changed the base branch from fe-changes to dev May 21, 2024 03:32
@balakrishna-deriv balakrishna-deriv merged commit 2c0cd84 into deriv-com:dev Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramin-deriv ramin-deriv ramin-deriv approved these changes

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@kate-deriv kate-deriv kate-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmadtaimoor-deriv @ramin-deriv @balakrishna-deriv @kate-deriv