Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suisin/chore: implement country code dropdown for real account sign up #17730

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

suisin-deriv
Copy link
Contributor

@suisin-deriv suisin-deriv commented Dec 4, 2024

Changes:

This PR is to implement country code dropdown behind a feature flag for real account sign up

Screenshots:

CR
Screenshot 2024-12-05 at 11 14 35 AM
EU
Screenshot 2024-12-05 at 11 19 01 AM

Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 5, 2024 6:54am

Copy link
Contributor

github-actions bot commented Dec 4, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17730](https://github.com/deriv-com/deriv-app/pull/17730)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-suisin-deriv-suisin-signupcountrycode-23249c.binary.sx?qa_server=red.derivws.com&app_id=31481
    - **Original**: https://deriv-app-git-fork-suisin-deriv-suisin-signupcountrycode-23249c.binary.sx
- **App ID**: `31481`

Copy link
Contributor

github-actions bot commented Dec 4, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 32
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-suisin-deriv-suisin-signupcountrycode-23249c.binary.sx/

@coveralls
Copy link

coveralls commented Dec 5, 2024

Pull Request Test Coverage Report for Build 12174465345

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 19 of 33 (57.58%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.7%) to 54.618%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/account/src/Configs/personal-details-config.ts 0 2 0.0%
packages/account/src/Components/forms/personal-details-form.jsx 8 13 61.54%
packages/core/src/App/Containers/RealAccountSignup/account-wizard.jsx 5 12 41.67%
Files with Coverage Reduction New Missed Lines %
packages/account/src/Configs/personal-details-config.ts 1 0.0%
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
Totals Coverage Status
Change from base Build 12157590879: 0.7%
Covered Lines: 15926
Relevant Lines: 26580

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Feb 4, 2025

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants