fix: revert the redirection changes #421
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview Link: https://Rupato-Revert--chang.bot-65f.pages.dev
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the
useMobileMenuConfighook insrc/components/layout/header/mobile-menu/use-mobile-menu-config.tsxby removing unused imports and redundant logic related to feature flags and wallet accounts. It also updates the account settings URL logic to use a static route.Code cleanup and simplification:
useGrowthbookGetFeatureValueand its associated logic for retrieving feature flag values. [1] [2]has_walletcheck and thegetRedirectUrlfunction, which dynamically determined the redirect URL based on the user's country and wallet status.Static URL update:
hrefproperty for the "Account Settings" menu item to use a static route (standalone_routes.account_settings) instead of relying on the removedgetRedirectUrlfunction.