Skip to content

Commit

Permalink
Revert "perf: use jemalloc as global allocator (#18957)" (#19187)
Browse files Browse the repository at this point in the history
This reverts commit 798c1ad.

Reverting because this change caused a spike in memory usage, but we
can't fully realise gains from lower GC pressure from more optimal
malloc/ free provided by "jemalloc". 

We might revisit the topic in future.
  • Loading branch information
bartlomieju authored May 19, 2023
1 parent 2b92efa commit af72a9c
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 33 deletions.
21 changes: 0 additions & 21 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,6 @@ tar = "=0.4.38"
tempfile = "3.4.0"
thiserror = "1.0.40"
tokio = { version = "1.28.1", features = ["full"] }
tikv-jemallocator = "0.5.0"
tikv-jemalloc-sys = "0.5.3"
tokio-rustls = "0.24.0"
tokio-util = "0.7.4"
tower-lsp = { version = "=0.17.0", features = ["proposed"] }
Expand Down
3 changes: 0 additions & 3 deletions cli/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,6 @@ winapi = { workspace = true, features = ["knownfolders", "mswsock", "objbase", "
[target.'cfg(unix)'.dependencies]
nix.workspace = true

[target.'cfg(not(target_env = "msvc"))'.dependencies]
tikv-jemallocator.workspace = true

[dev-dependencies]
deno_bench_util.workspace = true
dotenv = "=0.15.0"
Expand Down
7 changes: 0 additions & 7 deletions cli/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@ mod version;
mod watcher;
mod worker;

#[cfg(not(target_env = "msvc"))]
use tikv_jemallocator::Jemalloc;

#[cfg(not(target_env = "msvc"))]
#[global_allocator]
static GLOBAL: Jemalloc = Jemalloc;

use crate::args::flags_from_vec;
use crate::args::DenoSubcommand;
use crate::args::Flags;
Expand Down

0 comments on commit af72a9c

Please sign in to comment.