feat: add SubmitAPI configuration and integration #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzalezzfelipe
requested changes
Oct 24, 2025
proxy/src/config.rs
Outdated
| env::set_var("DOLOS_ENDPOINTS", r"/blocks/,/epochs/"); | ||
| env::set_var("SUBMITAPI_PORT", "8090"); | ||
| env::set_var("SUBMITAPI_DNS", "ext-submitapi-m1"); | ||
| env::set_var("SUBMITAPI_ENDPOINTS", r"/tx/submit"); |
There was a problem hiding this comment.
I don't think this should be configurable, we already know that that is the only endpoint
There was a problem hiding this comment.
Perfect, I will remove the ENDPOINTS variable from the code 🙌
proxy/src/proxy.rs
Outdated
Comment on lines
238
to
239
| //eg: internal-cardano-mainnet-submitapi.ext-submitapi-m1.svc.cluster.local:8090 | ||
| "internal-{}-submitapi.{}:{}", |
There was a problem hiding this comment.
This doesn't exist I think.
There was a problem hiding this comment.
I based on the dolos one, but not sure which one will be the submitapi, we can fix that wtih a real one
There was a problem hiding this comment.
You need to check in what service the submitapi pods can be found on the cluster. Particularly, it is submitapi-cardano-mainnet, submitapi-cardano-preprod, etc
There was a problem hiding this comment.
Perfect! So, I updated to that format 🙌
gonzalezzfelipe
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.