Skip to content

added hyperlinks #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nshejwalkar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

added hyperlinks #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions chrome/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ function toLocalISOString(date) {
function addArticleToTree(title, url, parentUrl) {
// If there's no parent, this is a root article
if (!parentUrl) {
articlesTree[url] = articlesTree[url] || { title, children: {} };
articlesTree[url] = articlesTree[url] || { title, url, children: {} };
} else {
// Recursively search for the parent node in the tree
const parentNode = findParentNode(articlesTree, parentUrl);
if (parentNode) {
// Add the article under its parent
parentNode.children[url] = parentNode.children[url] || { title, children: {} };
parentNode.children[url] = parentNode.children[url] || { title, url, children: {} };
} else {
// If the parent node is not found, treat it as a root article
articlesTree[url] = articlesTree[url] || { title, children: {} };
articlesTree[url] = articlesTree[url] || { title, url, children: {} };
}
}
// Save the updated tree to storage
Expand Down
19 changes: 11 additions & 8 deletions chrome/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,17 @@ document.addEventListener('DOMContentLoaded', function() {
.attr("fill", d => d.children ? "#555" : "#999")
.attr("r", 2.5);

node.append("text")
.attr("dy", "0.31em")
.attr("x", d => d.children ? -6 : 6)
.attr("text-anchor", d => d.children ? "end" : "start")
.text(d => d.data.title)
.attr("fill", "black") // Set the text color
.clone(true).lower()
.attr("stroke", "white"); // Remove the stroke or set to a contrasting color if needed
node.append("a")
.attr("xlink:href", d => d.data.url || null)
.attr("target", "_blank") // Opens link in a new tab
.append("text")
.attr("dy", "0.31em")
.attr("x", d => d.children ? -6 : 6)
.attr("text-anchor", d => d.children ? "end" : "start")
.text(d => d.data.title)
.attr("fill", "black") // Set the text color
.clone(true).lower()
.attr("stroke", "white"); // Remove the stroke or set to a contrasting color if needed


// Add this SVG to your popup
Expand Down
6 changes: 3 additions & 3 deletions firefox/background.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,16 @@ function toLocalISOString(date) {
function addArticleToTree(title, url, parentUrl) {
// If there's no parent, this is a root article
if (!parentUrl) {
articlesTree[url] = articlesTree[url] || { title, children: {} };
articlesTree[url] = articlesTree[url] || { title, url, children: {} };
} else {
// Recursively search for the parent node in the tree
const parentNode = findParentNode(articlesTree, parentUrl);
if (parentNode) {
// Add the article under its parent
parentNode.children[url] = parentNode.children[url] || { title, children: {} };
parentNode.children[url] = parentNode.children[url] || { title, url, children: {} };
} else {
// If the parent node is not found, treat it as a root article
articlesTree[url] = articlesTree[url] || { title, children: {} };
articlesTree[url] = articlesTree[url] || { title, url, children: {} };
}
}
// Save the updated tree to storage
Expand Down
19 changes: 11 additions & 8 deletions firefox/popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,17 @@ document.addEventListener('DOMContentLoaded', function() {
.attr("fill", d => d.children ? "#555" : "#999")
.attr("r", 2.5);

node.append("text")
.attr("dy", "0.31em")
.attr("x", d => d.children ? -6 : 6)
.attr("text-anchor", d => d.children ? "end" : "start")
.text(d => d.data.title)
.attr("fill", "black") // Set the text color
.clone(true).lower()
.attr("stroke", "white"); // Remove the stroke or set to a contrasting color if needed
node.append("a")
.attr("xlink:href", d => d.data.url || null)
.attr("target", "_blank") // Opens link in a new tab
.append("text")
.attr("dy", "0.31em")
.attr("x", d => d.children ? -6 : 6)
.attr("text-anchor", d => d.children ? "end" : "start")
.text(d => d.data.title)
.attr("fill", "black") // Set the text color
.clone(true).lower()
.attr("stroke", "white"); // Remove the stroke or set to a contrasting color if needed


// Add this SVG to your popup
Expand Down