fix memory leak in ts client.

Old Promises including their return values were not garbage collected, because they were not removed from the `_requests` Map. fixes #60
deltachat · Jul 6, 2024 · d62b2d7 · d62b2d7
1 parent 7d3b017
commit d62b2d7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 All notable changes to this project will be documented in this file.
 
+## Unreleased
+
+- ts client: fix memory leak
+
 ## 0.5.3 - 2023-12-02
 
 - Update axum

diff --git a/typescript/client.ts b/typescript/client.ts
@@ -38,6 +38,7 @@ export abstract class BaseTransport<T = {}>
     if (!response.id) return; // TODO: Handle error.
     const handler = this._requests.get(response.id);
     if (!handler) return; // TODO: Handle error.
+    this._requests.delete(response.id)
     if (response.error) handler.reject(response.error);
     else handler.resolve(response.result);
   }