[Spark] Translate old property ucTableId to io.unitycatalog.tableId when creating a new table. #5609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yili-db
force-pushed
the
property_translate
branch
2 times, most recently
from
eab335e to
4b812f3
Compare
openinx
reviewed
Dec 3, 2025
| if (DeltaSourceUtils.isDeltaDataSourceName(getProvider(properties))) { | ||
| // TODO: we should extract write options from table properties for all the cases. We | ||
| // can remove the UC check when we have confidence. | ||
| val respectOptions = isUnityCatalog || properties.containsKey("test.simulateUC") |
Collaborator
There was a problem hiding this comment.
What's the original intention for the test.simulateUC? Seems like it's for testing purposes, but do you know more about the context ?
Collaborator
Author
There was a problem hiding this comment.
Yes it's just for testing purpose in test test("CREATE TABLE with OPTIONS").
In the new test I added I also used it.
openinx
reviewed
Dec 3, 2025
| properties: util.Map[String, String]) : Table = | ||
| recordFrameProfile("DeltaCatalog", "createTable") { | ||
| if (DeltaSourceUtils.isDeltaDataSourceName(getProvider(properties))) { | ||
| // TODO: we should extract write options from table properties for all the cases. We |
Collaborator
There was a problem hiding this comment.
I will invite @cloud-fan to help co-review this PR, since he left this TODO comments.
openinx
reviewed
Dec 3, 2025
| */ | ||
| private def translateCatalogOwnedFeature(props: util.Map[String, String]): Unit = { | ||
| val removedValue = Option(props.remove(CatalogOwnedTableFeature.oldPropertyKey)) | ||
| removedValue.foreach(props.putIfAbsent(CatalogOwnedTableFeature.propertyKey, _)) |
Collaborator
There was a problem hiding this comment.
What's the value of the CatalogOwnedTableFeature.propertyKey ? I did not see it in the codebase...
Collaborator
Author
There was a problem hiding this comment.
I have added this as a val of TableFeature. It's:
/** The table property config key. */
val propertyKey: String = TableFeatureProtocolUtils.propertyKey(name)
And its specific value is delta.feature.catalogManaged
openinx
reviewed
Dec 3, 2025
| /** | ||
| * The table feature CatalogOwnedTableFeature was once renamed from an old name. In a transition | ||
| * period we need to translate the old table feature property name set by caller to new one. | ||
| * TODO: clean up once callers are migrated. |
Collaborator
There was a problem hiding this comment.
Do we need to explain what are the version that we need to keep this for the compatibility issue ?
Collaborator
Author
There was a problem hiding this comment.
Primarily for UC-Spark 0.3.1. But it doesn't exist yet so I hesitated to put the specific number in comment.
yili-db
force-pushed
the
property_translate
branch
from
8aa9f99 to
5a86d6c
Compare
…en creating a new table. Signed-off-by: Yi Li <[email protected]>
Signed-off-by: Yi Li <[email protected]>
yili-db
force-pushed
the
property_translate
branch
from
5a86d6c to
c2f7080
Compare
yili-db
changed the title
tdas
approved these changes
Dec 10, 2025
TimothyW553
pushed a commit
to TimothyW553/delta
that referenced
this pull request
Dec 10, 2025
…hen creating a new table. (delta-io#5609) #### Which Delta project/connector is this regarding? - [X] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description [Spark] Translate old property ucTableId to io.unitycatalog.tableId when creating a new table. This table property was renamed by delta-io#5534. However caller to AbstractDeltaCatalog.createTable (UCSingleCatalog from unitycatalog-spark) still sets the old property name and new property name in its current release. This change is needed until UCSingleCatalog moves away from the old table property name. ## How was this patch tested? A test is added in DeltaDDLSuite to exercise the table creation with old property name. ## Does this PR introduce _any_ user-facing changes? No. --------- Signed-off-by: Yi Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
[Spark] Translate old property ucTableId to io.unitycatalog.tableId when creating a new table.
This table property was renamed by #5534. However caller to AbstractDeltaCatalog.createTable (UCSingleCatalog from unitycatalog-spark) still sets the old property name and new property name in its current release. This change is needed until UCSingleCatalog moves away from the old table property name.
How was this patch tested?
A test is added in DeltaDDLSuite to exercise the table creation with old property name.
Does this PR introduce any user-facing changes?
No.