Rename table loading methods in DeltaCatalog for clarity #5587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan233usc
reviewed
Nov 26, 2025
| @Override | ||
| public Table newDeltaCatalogBasedTable(Identifier ident, CatalogTable catalogTable) { | ||
| return createBasedOnV2Mode( | ||
| public Table loadCatalogManagedTable(Identifier ident, CatalogTable catalogTable) { |
Collaborator
There was a problem hiding this comment.
Maybe add a comments to say that the table is backed by a catalog, or name it catalogBased.
CatalogManaged may cause confusion with Delta table with catalogManaged table feature 4ed3bbb
raveeram-db
approved these changes
Nov 26, 2025
huan233usc
approved these changes
Nov 26, 2025
TimothyW553
pushed a commit
to TimothyW553/delta
that referenced
this pull request
Dec 2, 2025
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description Follow-up of delta-io#5501. Rename table loading methods to better reflect their purpose: - `newDeltaCatalogBasedTable` → `loadCatalogTable` - `newDeltaPathTable` → `loadPathTable` - `createBasedOnV2Mode` → `loadTableInternal` Updated corresponding Javadoc comments from "Creates" to "Loads" to match the method semantics. ## How was this patch tested? Existing tests ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. --> No
zikangh
pushed a commit
to zikangh/delta
that referenced
this pull request
Dec 2, 2025
<!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [x] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description Follow-up of delta-io#5501. Rename table loading methods to better reflect their purpose: - `newDeltaCatalogBasedTable` → `loadCatalogTable` - `newDeltaPathTable` → `loadPathTable` - `createBasedOnV2Mode` → `loadTableInternal` Updated corresponding Javadoc comments from "Creates" to "Loads" to match the method semantics. ## How was this patch tested? Existing tests ## Does this PR introduce _any_ user-facing changes? <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. --> No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Follow-up of #5501.
Rename table loading methods to better reflect their purpose:
newDeltaCatalogBasedTable→loadCatalogTablenewDeltaPathTable→loadPathTablecreateBasedOnV2Mode→loadTableInternalUpdated corresponding Javadoc comments from "Creates" to "Loads" to match the method semantics.
How was this patch tested?
Existing tests
Does this PR introduce any user-facing changes?
No