DLPX-95475 Remove JAVA_HOME variable dependency from global environment file #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyash-jai
force-pushed
the
dlpx/pr/suyash-jai/0ad8b6bb-128e-4f9e-a9dd-48ef57a8b430
branch
from
3bd7428 to
d704e8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of https://github.com/delphix/dms-core-gate/pull/1900, we are removing the dependency on the global JAVA_HOME variable and instead setting separate JAVA_HOME values for the Masking and Virtualization services. The issue is that the file
files/common/var/lib/delphix-platform/ansible/10-delphix-platform/roles/delphix-platform/tasks/main.ymlreintroduces the JAVA_HOME variable into the global/etc/environmentfile.Solution
We have added JAVA_HOME variable for each service seperately and removing JAVA_HOME from global environment file and also removing the code which set again JAVA_HOME variable from this file
files/common/var/lib/delphix-platform/ansible/10-delphix-platform/roles/delphix-platform/tasks/main.ymlTesting Done
Provide a clear description of how this change was tested. At minimum
this should include proof that a computer has executed the changed
lines. Ideally this should include an automated test or an explanation
as to why this pull request has no tests.