Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/locust]: Updates master.auth.enabled to fix newer login method #627

Merged

Conversation

byronmansfield
Copy link
Contributor

Description

Updates master.auth.enabled to fix newer login method. Also updated to the latest tag

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@byronmansfield byronmansfield requested a review from a team as a code owner November 9, 2024 01:03
@byronmansfield
Copy link
Contributor Author

@max-rocket-internet so I tried using the version 0.31.{7.8} and realized something. I should have done better testing from my last PR. The new web ui auth method does not accept un/pw anymore. So this is the fix for that. Here is a working example I've been fooling around with. Seems to be working ok for me. But you apparently now have to write some custom python for it. It should be in this locustfile. I hope I made ok and understandable comments in the values file. Suggestions welcome.

Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @byronmansfield 💛

@max-rocket-internet max-rocket-internet merged commit 4773750 into deliveryhero:master Nov 11, 2024
5 checks passed
@max-rocket-internet
Copy link
Member

so I tried using the version 0.31.{7.8} and realized something. I should have done better testing from my last PR

No worries, that's why helm charts are versioned 🙂

@byronmansfield byronmansfield deleted the locust-updates branch November 16, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants