Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable/prometheus-statsd-exporter] add ServiceMonitor support for prometheus-statsd-exporter #578

Merged
merged 5 commits into from
Apr 22, 2024
Merged

[stable/prometheus-statsd-exporter] add ServiceMonitor support for prometheus-statsd-exporter #578

merged 5 commits into from
Apr 22, 2024

Conversation

abarrak
Copy link
Contributor

@abarrak abarrak commented Apr 21, 2024

Description

This supports prometheus extension for service monitor CRD optionally.

Checklist

  • Title of the PR starts with chart name (e.g. [stable/mychartname])
  • I have read the contribution instructions, bumped chart version and regenerated the docs
  • Github actions are passing

@abarrak abarrak requested a review from a team as a code owner April 21, 2024 10:32
max-rocket-internet
max-rocket-internet approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice but you need to regenerate the chart readme etc

@abarrak
Copy link
Contributor Author

abarrak commented Apr 22, 2024

Hi @max-rocket-internet, the docs are updated.

@abarrak
Copy link
Contributor Author

abarrak commented Apr 22, 2024

Tests output:

❯ ct lint --charts stable/prometheus-statsd-exporter
Linting charts...
Version increment checking disabled.

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 prometheus-statsd-exporter => (version: "0.1.3", path: "stable/prometheus-statsd-exporter")
------------------------------------------------------------------------------------------------------------------------

Linting chart "prometheus-statsd-exporter => (version: \"0.1.3\", path: \"stable/prometheus-statsd-exporter\")"
Validating /Users/aalotai1/sre_home/code/dh-helm-charts/stable/prometheus-statsd-exporter/Chart.yaml...
Validation success! 👍
Validating maintainers...
==> Linting stable/prometheus-statsd-exporter
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ prometheus-statsd-exporter => (version: "0.1.3", path: "stable/prometheus-statsd-exporter")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

helm-conftest running for chart: stable/prometheus-statsd-exporter...

45 tests, 45 passed, 0 warnings, 0 failures, 0 exceptions
==============================================================

@max-rocket-internet
Copy link
Member

max-rocket-internet commented Apr 22, 2024 •
edited
Loading

@abarrak just run this from repo root and commit the changes:

docker run --rm -v "$(git rev-parse --show-toplevel):/helm-docs" jnorwood/helm-docs:v1.11.3 --template-files ./ci/README.md.gotmpl

@abarrak
Copy link
Contributor Author

abarrak commented Apr 22, 2024

Sorry @max-rocket-internet, just fixed now.

❯ nerdctl run --rm -v "$(git rev-parse --show-toplevel):/helm-docs" jnorwood/helm-docs:v1.11.3 --template-files ./ci/README.md.gotmpl
docker.io/jnorwood/helm-docs:v1.11.3:                                             resolved       |++++++++++++++++++++++++++++++++++++++| 
index-sha256:c9b1a275ddc60ea1de290ced305dcc1412543e0624123d8b5182758880b12499:    done           |++++++++++++++++++++++++++++++++++++++| 
...
time="2024-04-22T12:43:38Z" level=info msg="Generating README Documentation for chart stable/prometheus-statsd-exporter"

max-rocket-internet
max-rocket-internet approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, got there in the end 😃

@max-rocket-internet max-rocket-internet merged commit 913e63a into deliveryhero:master Apr 22, 2024
5 checks passed
fekaiser pushed a commit to gastromatic/delivery-hero-helm-charts that referenced this pull request Oct 23, 2024
@abarrak @fekaiser
[stable/prometheus-statsd-exporter] add ServiceMonitor support for pr…
086bf41 
…ometheus-statsd-exporter (deliveryhero#578)

* add svm support for prometheus-statsd-exporter

* docs: add metrics vars docs for prometheus-statsd-exporter

* bump chart version

* fix docs linter

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abarrak @max-rocket-internet