Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable/kubecost-reports-exporter] add deadline and ttl second specs #567

Merged
merged 5 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/check_pr.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: "PR Title Checker"
on:
pull_request:
types:
- opened
- edited
- synchronize

jobs:
check_pr_title:
name: check PR title
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v2
- uses: deepakputhraya/action-pr-title@master
with:
regex: '^\[stable\/+.+]\s.+'
prefix_case_sensitive: false
8 changes: 8 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
repos:
- repo: https://github.com/norwoodj/helm-docs
rev: v1.11.0
hooks:
- id: helm-docs
args:
- --chart-search-root=stable
- --template-files=../ci/README.md.gotmpl
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ This repository has multiple Github Actions to ensure quality is high, these inc

- [chart-testing](https://github.com/helm/chart-testing): lint and install tests
- [markdown-lint](https://github.com/avto-dev/markdown-lint): lint all markdown files
- [pre-commit](https://pre-commit.com/): Auto generate helm docs before commit.
- [helm-docs](https://github.com/norwoodj/helm-docs): check all chart `README.md` have all values documented
- [helm-conftest](https://github.com/instrumenta/helm-conftest): Ensures standard labels are present

Expand Down Expand Up @@ -120,7 +121,13 @@ All commands to be run from the root of this repo.
To generate chart `README.md` files from the [template](ci/README.md.gotmpl):

```console
<!-- docker -->
docker run --rm -v "${PWD}:/helm-docs" jnorwood/helm-docs:v1.11.3 --template-files ./ci/README.md.gotmpl
<!-- pre-commit -->
# install pre-commit https://pre-commit.com/#install
$ brew install pre-commit
$ pre-commit install
$ pre-commit install-hooks
```

`helm-conftest`:
Expand Down
2 changes: 1 addition & 1 deletion stable/kubecost-reports-exporter/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ description: |
if you are using old installation please use v1 chart
home: https://www.kubecost.com
type: application
version: 2.0.3
version: 2.0.4
appVersion: "2.0.0"
maintainers:
- name: nyambati
Expand Down
4 changes: 3 additions & 1 deletion stable/kubecost-reports-exporter/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# kubecost-reports-exporter

![Version: 2.0.3](https://img.shields.io/badge/Version-2.0.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.0.0](https://img.shields.io/badge/AppVersion-2.0.0-informational?style=flat-square)
![Version: 2.0.4](https://img.shields.io/badge/Version-2.0.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.0.0](https://img.shields.io/badge/AppVersion-2.0.0-informational?style=flat-square)

Helm chart for exporting kubernetes cost reports to AWS s3 bucket.
N/B We have updated chart to use V2 scripts using allocations and assets api.
Expand Down Expand Up @@ -48,6 +48,7 @@ helm install my-release deliveryhero/kubecost-reports-exporter -f values.yaml

| Key | Type | Default | Description |
|-----|------|---------|-------------|
| activeDeadlineSeconds | int | `20` | |
| affinity | object | `{}` | |
| concurrencyPolicy | string | `"Forbid"` | |
| env | object | `{}` | Extra environment variables |
Expand Down Expand Up @@ -77,6 +78,7 @@ helm install my-release deliveryhero/kubecost-reports-exporter -f values.yaml
| serviceAccount.name | string | `""` | |
| successfulJobsHistoryLimit | int | `1` | |
| tolerations | list | `[]` | |
| ttlSecondsAfterFinished | int | `0` | |

## Maintainers

Expand Down
2 changes: 1 addition & 1 deletion stable/kubecost-reports-exporter/docker/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
boto3>=0.17.0
sentry-sdk==1.3.1
sentry-sdk==1.14.0
datadog-api-client>=2.0.0
requests
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,11 @@ spec:
successfulJobsHistoryLimit: {{ $.Values.successfulJobsHistoryLimit }}
failedJobsHistoryLimit: {{ $.Values.failedJobsHistoryLimit }}
concurrencyPolicy: {{ $.Values.concurrencyPolicy }}

jobTemplate:
spec:
activeDeadlineSeconds: {{ $.Values.activeDeadlineSeconds }}
ttlSecondsAfterFinished: {{ $.Values.ttlSecondsAfterFinished }}
template:
metadata:
{{- with $.Values.podAnnotations }}
Expand Down
2 changes: 2 additions & 0 deletions stable/kubecost-reports-exporter/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ restartPolicy: OnFailure
successfulJobsHistoryLimit: 1
failedJobsHistoryLimit: 1
concurrencyPolicy: Forbid
activeDeadlineSeconds: 20
ttlSecondsAfterFinished: 0

image:
# image.repository -- The container image to use
Expand Down
Loading