Skip to content

feat: reduce league table to P, GD, Pts columns only #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dejanvasic85 merged 5 commits into from
Jun 27, 2026
Merged

feat: reduce league table to P, GD, Pts columns only #689

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3c73454
feat: reduce league table to P, GD, Pts columns only
claude Jun 27, 2026
6ebd2e9
feat: constrain league table to viewport width with team name truncation
claude Jun 27, 2026
09ea8bc
feat: show all columns on desktop, only P/GD/Pts on mobile
claude Jun 27, 2026
7bc899c
fix: cap team column width on desktop to prevent stat columns overflo…
claude Jun 27, 2026
cb34b1d
fix: use middle truncation for team names to distinguish similar entries
claude Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 38 additions & 14 deletions src/components/teams/LeagueTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,16 @@ type Column = {
label: string;
shortLabel: string;
key: keyof TableEntry;
mobileHidden?: boolean;
};

const columns: Column[] = [
{ label: 'Played', shortLabel: 'P', key: 'played' },
{ label: 'Won', shortLabel: 'W', key: 'wins' },
{ label: 'Drawn', shortLabel: 'D', key: 'draws' },
{ label: 'Lost', shortLabel: 'L', key: 'losses' },
{ label: 'Goals For', shortLabel: 'GF', key: 'goalsFor' },
{ label: 'Goals Against', shortLabel: 'GA', key: 'goalsAgainst' },
{ label: 'Won', shortLabel: 'W', key: 'wins', mobileHidden: true },
{ label: 'Drawn', shortLabel: 'D', key: 'draws', mobileHidden: true },
{ label: 'Lost', shortLabel: 'L', key: 'losses', mobileHidden: true },
{ label: 'Goals For', shortLabel: 'GF', key: 'goalsFor', mobileHidden: true },
{ label: 'Goals Against', shortLabel: 'GA', key: 'goalsAgainst', mobileHidden: true },
{ label: 'Goal Difference', shortLabel: 'GD', key: 'goalDifference' },
{ label: 'Points', shortLabel: 'Pts', key: 'points' }
];
Expand All @@ -35,19 +36,33 @@ function resolveEntryDisplayName(entry: TableEntry, duplicateClubNames: Set<stri
return duplicateClubNames.has(entry.clubName) ? entry.teamName : entry.clubName;
}

const maxNameLength = 30;
const backChars = 10;

function truncateMiddle(text: string): string {
if (text.length <= maxNameLength) return text;
return `${text.slice(0, maxNameLength - backChars - 3)}...${text.slice(-backChars)}`;
}

export function LeagueTable({ entries }: LeagueTableProps) {
const { wscClubDriblName } = getClubConfig();
const duplicateClubNames = buildDuplicateClubNames(entries);

return (
<div className="overflow-x-auto">
<div className="overflow-hidden md:overflow-x-auto">
<table className="table-zebra table w-full text-sm">
<thead>
<tr>
<th className="w-8 text-center">#</th>
<th>Team</th>
<th className="w-6 px-1 text-center md:w-8 md:px-4">#</th>
<th className="min-w-0 md:min-w-fit">Team</th>
{columns.map((col) => (
<th key={col.key} className="text-center">
<th
key={col.key}
className={[
'w-10 px-1 text-center md:w-auto md:px-4',
col.mobileHidden ? 'hidden md:table-cell' : ''
].join(' ')}
>
<span className="sr-only">{col.label}</span>
<span aria-hidden="true">{col.shortLabel}</span>
</th>
Expand All @@ -62,8 +77,8 @@ export function LeagueTable({ entries }: LeagueTableProps) {
key={entry.teamId}
className={isWsc ? 'bg-secondary/10 font-semibold' : undefined}
>
<td className="text-center tabular-nums">{entry.position}</td>
<td>
<td className="px-1 text-center tabular-nums md:px-4">{entry.position}</td>
<td className="max-w-0 min-w-0 md:max-w-64">
<div className="flex items-center gap-2">
<Image
src={entry.logoUrl}
Expand All @@ -73,13 +88,22 @@ export function LeagueTable({ entries }: LeagueTableProps) {
className="shrink-0 rounded-full object-contain"
unoptimized
/>
<span className="truncate">
{resolveEntryDisplayName(entry, duplicateClubNames)}
<span
className="truncate"
title={resolveEntryDisplayName(entry, duplicateClubNames)}
>
{truncateMiddle(resolveEntryDisplayName(entry, duplicateClubNames))}
</span>
</div>
</td>
{columns.map((col) => (
<td key={col.key} className="text-center tabular-nums">
<td
key={col.key}
className={[
'px-1 text-center tabular-nums md:px-4',
col.mobileHidden ? 'hidden md:table-cell' : ''
].join(' ')}
>
{entry[col.key] as number}
</td>
))}
Expand Down
Loading