Skip to content

Conversation

@jeremy5189
Copy link
Contributor

No description provided.

@jeremy5189 jeremy5189 requested a review from Copilot October 15, 2025 19:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes Kafka reader and dialer configuration more flexible by externalizing previously hardcoded timeout and buffer size values. The changes allow these parameters to be configured via the YAML configuration file rather than being fixed in the code.

Key changes:

  • Replaces hardcoded Kafka dialer timeout (10s) and adds configurable keep-alive setting
  • Makes Kafka reader buffer sizes (MinBytes, MaxBytes) and MaxWait timeout configurable
  • Adds logging to track the configured Kafka reader parameters at startup

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
internal/config.go Adds five new configuration fields for Kafka reader and dialer settings
internal/kafka.go Updates dialer and reader initialization to use config values instead of hardcoded constants; adds logging for configuration visibility
banjax-config.yaml Defines default values for the new Kafka configuration parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jeremy5189 jeremy5189 merged commit 0dafc76 into main Oct 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants