Synchronizing Planemo test with Pytests for bamCompare and bamCoverage tool #1345
+146
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SaimMomin12 did you also check the other way around? including the addtional tests from planemo (if there are any) into pytests? |
|
@pavanvidem yes, the planemo tests are covered in the pytest for these both tools |
wm75
reviewed
Nov 27, 2024
| <param name="outFileFormat" value="bedgraph"/> | ||
| <param name="binSize" value="10"/> | ||
| <param name="type" value="ratio"/> | ||
| <param name="skipZeroOverZero" value="--skipZeroOverZero"/> |
There was a problem hiding this comment.
boolean params (I think this is one) should be tested with value="true"/value="false" instead of the eventual values.
This is a more stringent test because it checks also whether you typed the correct true/falsevalue in the input section.
There was a problem hiding this comment.
I see in the deeptools_macros.xml, skipZeroOverZero is defined as "select" param type.
There was a problem hiding this comment.
you're right though that seems wrong then by itself.
I'll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to deepTools GitHub repository! Please check the following regarding
your pull request :
This PR concerns with adding additional tests to bamCompare and bamCoverage tool to synchronize them with pytests.