Fix SuperOffloadOptimizer_Stage3 crash due to missing param_names parameter #7715
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Steiger <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in SuperOffloadOptimizer_Stage3 by adding the missing param_names parameter that was causing initialization failures when SuperOffload was enabled.
- Adds
param_namesparameter toSuperOffloadOptimizer_Stage3.__init__()signature - Passes
param_namesto parent classDeepSpeedZeroOptimizer_Stage3constructor
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
sfc-gh-truwase
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing param_names
parametertoSuperOffloadOptimizer_Stage3initializer, fixing a crash when using SuperOffload.Fixes #7627