Take **kwargs in __init__ of DeepSpeedZeroOptimizer subclasses #7634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepSpeedZeroOptimizer provides a rich, evolving list of keyword arguments. It is tedious and error-prone to list all of them in its subclasses. As an example, the recent introduction of zenflow_config in the middle of that list has caused unit test failures (e.g. https://github.com/deepspeedai/DeepSpeed/actions/runs/18560070656/job/52906645682?pr=7633) Convert the keyword argument list in DeepSpeedZeroOptimizer subclasses to **kwargs for the consistency of configurable items and their default values. Passing an unknown parameter to such subclasses will now raise an error on their call to DeepSpeedZeroOptimizer.__init__() instead of their own __init__(). It still ensures that typo in such parameters fail early. Signed-off-by: Junjie Mao <[email protected]>
Contributor
Author
|
It looks the CI still used the old code base (see https://github.com/deepspeedai/DeepSpeed/actions/runs/18582440763/job/52979937206?pr=7634#step:5:473). @sfc-gh-truwase Any idea what's going wrong here? |
Contributor
|
Hi @eternalNight, |
tohtana
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeepSpeedZeroOptimizer provides a rich, evolving list of keyword arguments. It is tedious and error-prone to list all of them in its subclasses. As an example, the recent introduction of zenflow_config in the middle of that list has caused unit test failures (e.g. https://github.com/deepspeedai/DeepSpeed/actions/runs/18560070656/job/52906645682?pr=7633)
Convert the keyword argument list in DeepSpeedZeroOptimizer subclasses to **kwargs for the consistency of configurable items and their default values. Passing an unknown parameter to such subclasses will now raise an error on their call to DeepSpeedZeroOptimizer.init() instead of their own init(). It still ensures that typo in such parameters fail early.