-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: Add Chat Generator supporting OpenAI Responses API #9808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 19132972551Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…tack into openai-responses
releasenotes/notes/add-openai-responses-chatgenerator-52ca7457a4e61db1.yaml
Show resolved
Hide resolved
|
@Amnah199 can we make sure to update the docs files in |
sjrl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| timeout: Optional[float] = None, | ||
| max_retries: Optional[int] = None, | ||
| tools: Optional[Union[ToolsType, list[dict]]] = None, | ||
| tools_strict: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjrl This value is True by default in Responses. For consistency with other chat generators I kept it false.
Related Issues
Proposed Changes:
responsesendpoint.initandrunmethods allows openai and MCP tools besides haystack Tools.text_formatingeneration_kwargs.generation_kwargs.backgroundrequests etc, which are not supported in this iteration.How did you test it?
Notes for the reviewer
Using OpenAI tools and MCP tools doesn’t behave like standard function calls.
type="function_call". However, for OpenAI/MCP tools, the type value varies depending on the tool being used — for example,type="web_search_call".ResponseFunctionToolCallobjects. As a result, tool calls from OpenAI/MCP tools won’t appear in theChatMessage, so the user won’t see them.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.