-
Notifications
You must be signed in to change notification settings - Fork 200
feat: add CometAPI integration with CometAPIChatGenerator class and configuration #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…Embedder and GoogleAIDocumentEmbedder
…entEmbedder and GoogleAITextEmbedder tests
…der to use private attributes for initialization
…document embedder and tests
…der and GoogleGenAITextEmbedder
Google genai embedders async runs
…IDocumentEmbedder
…atch_async method
...ons/cometapi/src/haystack_integrations/components/generators/cometapi/chat/chat_generator.py
Show resolved
Hide resolved
1. enforcing keyword arguments for all init params 2. updated workflow
|
@sjrl @mpangrazzi I have done the changes ✅ |
|
Hi @sjrl @mpangrazzi just wanted to check you both if you can give it a review, so I can fix things if required any changes. |
mpangrazzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@garybadwal I've checked the README but it's still not consistent with other integrations' README. It should have only package links and a Contributing section (example).
Then you can make another PR here with examples and an Usage section.
|
@mpangrazzi Done ✅, I made the changes i the Readme File. |
|
Hi @sjrl @mpangrazzi hope you both are doing great, I wanted to check with you if you got the time to review my PR. Is it fine or we need more changes in this. |
|
@garybadwal Thanks for the updates! We'll review again soon |
mpangrazzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a minor comment, which triggers a warning during tests.
Related Issues
Proposed Changes
Added a new
CometAPIChatGeneratorclass that extendsOpenAIChatGeneratorto support the Comet API as a backend for chat generation.api_base_urlto point tohttps://api.cometapi.com/v1.COMET_API_KEYenvironment variable (usingSecret.from_env_var).OpenAIChatGenerator.gpt-4o-mini.This provides a seamless way to use CometAPI as a drop-in replacement for OpenAI within Haystack.
How did you test it?
CometAPIChatGeneratorwith and without explicit parameters.OpenAIChatGenerator.api_base_url=https://api.cometapi.com/v1).COMET_API_KEY).Notes for the reviewer
CometAPIChatGeneratorclass.OpenAIChatGeneratorlogic, only customizingapi_base_urland defaults.Checklist
feat:in this case)